@bgribaudo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Learn Build status updates of commit 32dbf5f:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

@DougKlopfenstein

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

bgribaudo I suspect you are right about how the terminology was being used here, and I agree that this should be rephrased. I don't have a strong opinion on what we should change it to. The simplest might be to just say "primitive and nullable primitive types". I am also thinking of "optionally nullable primitive types", but this seems like it could still be confusing.

Thanks, @egorelik93!

What about calling these "non-custom types"?

This would correspond nicely with (e.g. it would be the exact inverse of) what the spec calls custom types: "All types that are not members of the closed set of primitive types plus their nullable counterparts are collectively referred to as custom types."

It seems like it would read clearly. Example:

The second argument to Type.Is should be a non-custom type value.

Another idea could be the name "simple types" (vs. "complex types"—i.e. the types that require (), [] or {} in their definition).

@egorelik93, hope your day is going well! Did you have any thoughts on this?

@bgribaudo The way other systems use the term 'complex types', it would include things like 'record' and 'list', so I don't think I want to go there. I was trying to figure out what is the opposite of 'custom', and I think I have my answer: 'built-in types'. That being said, while I like that phrasing, it's not a phrase we've ever used before. Not that 'non-custom types' is either, nor does it really flow on the tongue, but since 'custom types' is documented, I don't think it needs any explanation. On the other hand, I'd have no issue introducing a new term 'built-in types' either. @ehrenMSFT @DougKlopfenstein any thoughts?

@bgribaudo I take that back. 'Built-in types' could confuse people into thinking it include things like Int64.Type, which we don't want to go into. If 'primitive and nullable primitive' is too wordy, maybe let's just use 'non-custom' types.

primitive and nullable primitive

I think "primitive and nullable primitive" would be fine. It seems like that's the clearest option.

I'd also be fine with just saying "primitive", since most people would probably assume that includes the nullable versions of those types as well.

But if you want to be explicit and say "primitive and nullable primitive", I'm fine with that.

Thanks, @egorelik93 and @ehrenMSFT!

To me, a downside to just calling these types "primitive" is that that the term "primitive type" is given a specific meaning in the specification separate from the idea of nullable. Conflating the two could be confusing.

"Primitive and nullable primitive" covers it, but is a little wordy.

@egorelik93: If 'primitive and nullable primitive' is too wordy, maybe let's just use 'non-custom' types.

@ehrenMSFT, are you strongly opposed to "non-custom types?" :-) The spec currently defines a subset of types as "custom types." What we are talking about here is the opposite/alternate to that subset, so arguably the prefix "non-" covers what we need it to.

I'm fine with either "primitive and nullable primitive" or "non-custom".

Learn Build status updates of commit 5aae8fa:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

Learn Build status updates of commit a4149bb:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

@bgribaudo, @ehrenMSFT, @egorelik93 - Is this pull request ready to be merged?

@bgribaudo, @ehrenMSFT, @egorelik93 - Is this pull request ready to be merged?

I'd recommend waiting for @egorelik93 to sign off.

@bgribaudo I'm leaning back towards "primitive and nullable primitive". "non-custom" is fine for spec wizards but in isolation would be non-obvious.

Wouldn't someone have to be a bit familiar with the spec to know what the term "primitive" means, as well?

Learn Build status updates of commit 68a912d:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

@ehrenMSFT, @egorelik93, what do you think of this? :-)

Learn Build status updates of commit 7d5d05f:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

Hi @egorelik93 and @DougKlopfenstein! Happy New Year! Do you know the status of this PR? Thanks!

Learn Build status updates of commit da75a6b:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

• [Error: CannotMergeCommit] Cannot merge commit da75a6bc3d25ecbca6170789610603a85c1f140c in branch patch-8 of repository https://github.com/bgribaudo/query-docs into branch main (commit 7a878e1ef8ef435efc4557f5d251549a9deca62d). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

Learn Build status updates of commit 4e9de2f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

• [Error: CannotMergeCommit] Cannot merge commit 4e9de2f508b6179c2f030da5bbb7e218ee8db3a5 in branch patch-8 of repository https://github.com/bgribaudo/query-docs into branch main (commit 7a878e1ef8ef435efc4557f5d251549a9deca62d). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel

@egorelik93, thanks for the feedback. Any better now?

Learn Build status updates of commit 28ccf8c:

✅ Validation status: passed

For more details, please refer to the build report.

For any questions, please:

• Try searching the learn.microsoft.com contributor guides
• Post your question in the Learn support channel